Github user gvramana commented on a diff in the pull request:
https://github.com/apache/spark/pull/5393#discussion_r28392460
--- Diff: repl/pom.xml ---
@@ -150,6 +150,16 @@
</build>
<profiles>
<profile>
+ <id>hive</id>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-hive_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ </dependencies>
+ </profile>
+ <profile>
--- End diff --
No, dependency is added in hive profile only. So if assembly is built with
-Phive option then hive dependency is added to repl, so that hive is available
in class path for repl.
If assembly is built without -Phive option then dependency is not added and
the testcase is ignored. Testcase also checks runtime if hiveContext class is
available, if not testcase is ignored.
I have manually tested both the cases of building with -Phive and without
hive. It will not impact assembly creation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]