maropu commented on a change in pull request #30430:
URL: https://github.com/apache/spark/pull/30430#discussion_r529086328
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala
##########
@@ -64,7 +64,9 @@ case class SortOrder(
direction: SortDirection,
nullOrdering: NullOrdering,
sameOrderExpressions: Set[Expression])
Review comment:
> We can use ExpressionSet maybe at those 2 places and make it a Seq in
constructor here. any thoughts?
Yea, I think it is okay to just deduplicate it before storing it in the
class as you said, and then make it `Seq`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
