ulysses-you commented on a change in pull request #30412:
URL: https://github.com/apache/spark/pull/30412#discussion_r529097018
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala
##########
@@ -124,13 +125,16 @@ abstract class DataType extends AbstractDataType {
object DataType {
private val FIXED_DECIMAL = """decimal\(\s*(\d+)\s*,\s*(\-?\d+)\s*\)""".r
+ private val CHAR_TYPE = """char\(\s*(\d+)\s*\)""".r
+ private val VARCHAR_TYPE = """varchar\(\s*(\d+)\s*\)""".r
Review comment:
A question, do we need to support default length if user not give a
special value ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
