srowen commented on a change in pull request #30477:
URL: https://github.com/apache/spark/pull/30477#discussion_r529110340
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTable.scala
##########
@@ -156,7 +156,9 @@ class InMemoryTable(
throw new IllegalArgumentException(s"Match: unsupported
argument(s) type - ($v, $t)")
}
case BucketTransform(numBuckets, ref) =>
- (extractor(ref.fieldNames, schema, row).hashCode() &
Integer.MAX_VALUE) % numBuckets
+ val (value, dataType) = extractor(ref.fieldNames, schema, row)
+ val valueHashCode = if (value == null) 0 else value.hashCode
+ ((valueHashCode + dataType.hashCode()) & Integer.MAX_VALUE) %
numBuckets
Review comment:
Seems fine. One common hashCode pattern is a + 31 * b, in the JVM
source, FWIW.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
