Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28395272
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -102,6 +106,8 @@ case class Limit(limit: Int, child: SparkPlan)
override def output: Seq[Attribute] = child.output
override def outputPartitioning: Partitioning = SinglePartition
+ override def outputOrdering: Seq[SortOrder] = child.outputOrdering
--- End diff --
I am not sure it is correct. We are merging rows from multiple partitions
to a single partition and `outputOrdering` only guarantee the row ordering
within a single partition. Seems without merge sort, we cannot use
`child.outputOrdering`. How about we just remove it for now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
