AngersZhuuuu commented on a change in pull request #30421:
URL: https://github.com/apache/spark/pull/30421#discussion_r529403802
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -503,13 +503,32 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with
SQLConfHelper with Logg
}
}
+ def convertTypeConstructedLiteralToString(literal: Literal): String =
literal match {
Review comment:
Done
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2584,6 +2584,14 @@ abstract class SQLQuerySuiteBase extends QueryTest with
SQLTestUtils with TestHi
}
}
}
+
+ test("SPARK-33474: Support TypeConstructed partition spec value") {
+ withTable("t") {
+ sql("CREATE TABLE t(name STRING) PARTITIONED BY (part DATE) STORED AS
ORC")
Review comment:
> btw, why did you use `stored as orc` explicitly for this test?
removed
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2584,6 +2584,14 @@ abstract class SQLQuerySuiteBase extends QueryTest with
SQLTestUtils with TestHi
}
}
}
+
+ test("SPARK-33474: Support TypeConstructed partition spec value") {
+ withTable("t") {
+ sql("CREATE TABLE t(name STRING) PARTITIONED BY (part DATE) STORED AS
ORC")
Review comment:
> Please add more tests for the other types and add tests in
`DDLParserSuite`.
Both updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
