HyukjinKwon commented on a change in pull request #30486:
URL: https://github.com/apache/spark/pull/30486#discussion_r529582202
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -1537,8 +1575,14 @@ class SparkContext(config: SparkConf) extends Logging {
addFile(path, recursive, false)
}
- private def addFile(path: String, recursive: Boolean, addedOnSubmit:
Boolean): Unit = {
- val uri = new Path(path).toUri
+ private def addFile(
+ path: String, recursive: Boolean, addedOnSubmit: Boolean, isArchive:
Boolean = false
+ ): Unit = {
+ val uri = if (!isArchive) {
+ new Path(path).toUri
+ } else {
+ Utils.resolveURI(path)
Review comment:
Here we cannot rely on `new Path(path).toUri`. it makes the fragment
(`#`) in URI as the part of path. `Utils.resolveURI` is used for
`spark.yarn.dist.archives` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
