sunchao commented on a change in pull request #30491:
URL: https://github.com/apache/spark/pull/30491#discussion_r530040128
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -213,15 +213,14 @@ case class AtomicReplaceTableAsSelectExec(
* Rows in the output data set are appended.
*/
case class AppendDataExec(
- session: SparkSession,
table: SupportsWrite,
- relation: DataSourceV2Relation,
writeOptions: CaseInsensitiveStringMap,
- query: SparkPlan) extends V2TableWriteExec with BatchWriteHelper {
+ query: SparkPlan,
+ afterWrite: () => Unit = () => ()) extends V2TableWriteExec with
BatchWriteHelper {
override protected def run(): Seq[InternalRow] = {
val writtenRows = writeWithV2(newWriteBuilder().buildForBatch())
- session.sharedState.cacheManager.recacheByPlan(session, relation)
Review comment:
Yeah I'm fine by doing these together in another JIRA. One issue is that
the recache logic occurs in various Spark plans right now, and it would be nice
to put it in a central place (perhaps via another util trait?) so the code is
more manageable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
