mridulm commented on pull request #30446: URL: https://github.com/apache/spark/pull/30446#issuecomment-733832829
@tgravescs The question I had was regarding when redaction is applied - while logging the event or when surfacing in UI. Only for the case of `EventLoggingListener.onEnvironmentUpdate` we are redacting event file itself - in all other cases of application of redaction regex, we do not modify the event file, but rather change when presenting to user. I am not sure if this was done intentionally (allowing superuser to look at the unredact properties - and so `onEnvironmentUpdate` is a bug) or was an oversight (in which case all properties should be redacted before logging). Thoughts ? Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
