mridulm commented on pull request #29113: URL: https://github.com/apache/spark/pull/29113#issuecomment-733842598
Briefly looking at spark code, this is currently still in use - looks like that comment in `TaskEndReason` might not be valid anymore. See [here](https://github.com/apache/spark/blob/594c7c613a8ef80ab6b3725832579f12d40b02c8/core/src/main/scala/org/apache/spark/executor/Executor.scala#L694) for example. There are other uses as well, given that I am not in favor of this change. If it had been a truely dead code, I would have been more inclined to cleanup (with a caveat that this is part of public api, and so we need to be careful with breaking behavior). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
