cloud-fan commented on a change in pull request #30491:
URL: https://github.com/apache/spark/pull/30491#discussion_r530756566
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V1FallbackWriters.scala
##########
@@ -38,10 +38,10 @@ case class AppendDataExecV1(
table: SupportsWrite,
writeOptions: CaseInsensitiveStringMap,
plan: LogicalPlan,
- v2Relation: DataSourceV2Relation) extends V1FallbackWriters {
+ afterWrite: () => Unit) extends V1FallbackWriters {
Review comment:
shall we use a consistent name "refreshCache"?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V1FallbackWriters.scala
##########
@@ -61,7 +61,7 @@ case class OverwriteByExpressionExecV1(
deleteWhere: Array[Filter],
writeOptions: CaseInsensitiveStringMap,
plan: LogicalPlan,
- v2Relation: DataSourceV2Relation) extends V1FallbackWriters {
+ afterWrite: () => Unit) extends V1FallbackWriters {
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
