ScrapCodes commented on a change in pull request #30472:
URL: https://github.com/apache/spark/pull/30472#discussion_r530893082
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -90,6 +90,14 @@ private[spark] object Config extends Logging {
.toSequence
.createWithDefault(Nil)
+ val CONFIG_MAP_MAXSIZE =
+ ConfigBuilder("spark.kubernetes.configMap.maxsize")
+ .doc("Max size limit for a config map. This may be configurable as per" +
+ " https://etcd.io/docs/v3.4.0/dev-guide/limit/ in the future.")
+ .version("3.1.0")
Review comment:
"Max size limit for a config map. This is configurable as per
https://etcd.io/docs/v3.4.0/dev-guide/limit/ on k8s server end."
So may be we should keep it configurable too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
