bart-samwel commented on a change in pull request #29882:
URL: https://github.com/apache/spark/pull/29882#discussion_r531589627
##########
File path:
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/select_having.sql
##########
@@ -49,6 +49,7 @@ SELECT 1 AS one FROM test_having HAVING a > 1;
SELECT 1 AS one FROM test_having HAVING 1 > 2;
SELECT 1 AS one FROM test_having HAVING 1 < 2;
+-- [SPARK-33008] Spark SQL throws an exception
Review comment:
I think this test case is wrong -- the next line says that it's to prove
that we aren't scanning the table, but the condition `1 < 2` actually _does_
force us to scan the table. I think this test case should have used `HAVING 1 >
2`. Could you correct the test case and remove the comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
