maropu commented on a change in pull request #30515:
URL: https://github.com/apache/spark/pull/30515#discussion_r532041141
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MariaDBKrbIntegrationSuite.scala
##########
@@ -24,15 +24,21 @@ import com.spotify.docker.client.messages.{ContainerConfig,
HostConfig}
import
org.apache.spark.sql.execution.datasources.jdbc.connection.SecureConnectionProvider
import org.apache.spark.tags.DockerTest
+/**
+ * To run this test suite for a specific version (e.g., mariadb:10.5.8):
+ * {{{
+ * MARIADB_DOCKER_IMAGE_NAME=mariadb:10.5.8
+ * ./build/sbt -Pdocker-integration-tests
+ * "testOnly org.apache.spark.sql.jdbc.MariaDBKrbIntegrationSuite"
+ * }}}
+ */
@DockerTest
class MariaDBKrbIntegrationSuite extends DockerKrbJDBCIntegrationSuite {
override protected val userName = s"mariadb/$dockerIp"
override protected val keytabFileName = "mariadb.keytab"
override val db = new DatabaseOnDocker {
- // If you change `imageName`, you need to update the version of
`mariadb-plugin-gssapi-server`
- // in `resources/mariadb_docker_entrypoint.sh` accordingly.
- override val imageName = "mariadb:10.5"
+ override val imageName = sys.env.getOrElse("MARIADB_DOCKER_IMAGE",
"mariadb:10.5")
Review comment:
`MARIADB_DOCKER_IMAGE` -> `MARIADB_DOCKER_IMAGE_NAME`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
