srowen commented on a change in pull request #30530:
URL: https://github.com/apache/spark/pull/30530#discussion_r532124096
##########
File path: docs/sql-migration-guide.md
##########
@@ -333,7 +333,7 @@ license: |
</tr>
</table>
- - Since Spark 2.4, when there is a struct field in front of the IN operator
before a subquery, the inner query must contain a struct field as well. In
previous versions, instead, the fields of the struct were compared to the
output of the inner query. Eg. if `a` is a `struct(a string, b int)`, in Spark
2.4 `a in (select (1 as a, 'a' as b) from range(1))` is a valid query, while `a
in (select 1, 'a' from range(1))` is not. In previous version it was the
opposite.
+ - Since Spark 2.4, when there is a struct field in front of the IN operator
before a subquery, the inner query must contain a struct field as well. In
previous versions, instead, the fields of the struct were compared to the
output of the inner query. E.g. if `a` is a `struct(a string, b int)`, in Spark
2.4 `a in (select (1 as a, 'a' as b) from range(1))` is a valid query, while `a
in (select 1, 'a' from range(1))` is not. In previous version it was the
opposite.
Review comment:
Nit, for if we need to fix anything else: "E.g." probably should not
begin a sentence. "For example," is better
##########
File path: docs/sql-migration-guide.md
##########
@@ -532,11 +532,11 @@ license: |
- Since Spark 2.3, by default arithmetic operations between decimals return a
rounded value if an exact representation is not possible (instead of returning
NULL). This is compliant with SQL ANSI 2011 specification and Hive's new
behavior introduced in Hive 2.2 (HIVE-15331). This involves the following
changes
- - The rules to determine the result type of an arithmetic operation have
been updated. In particular, if the precision / scale needed are out of the
range of available values, the scale is reduced up to 6, in order to prevent
the truncation of the integer part of the decimals. All the arithmetic
operations are affected by the change, ie. addition (`+`), subtraction (`-`),
multiplication (`*`), division (`/`), remainder (`%`) and positive module
(`pmod`).
+ - The rules to determine the result type of an arithmetic operation have
been updated. In particular, if the precision / scale needed are out of the
range of available values, the scale is reduced up to 6, in order to prevent
the truncation of the integer part of the decimals. All the arithmetic
operations are affected by the change, i.e. addition (`+`), subtraction (`-`),
multiplication (`*`), division (`/`), remainder (`%`) and positive module
(`pmod`).
Review comment:
Also let's fix "positive module" to "positive modulus"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
