srowen commented on a change in pull request #30531:
URL: https://github.com/apache/spark/pull/30531#discussion_r532124529
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
##########
@@ -188,13 +188,13 @@ private[parquet] class ParquetRowConverter(
*/
def currentRecord: InternalRow = currentRow
- private val dateRebaseFunc = DataSourceUtils.creteDateRebaseFuncInRead(
+ private val dateRebaseFunc = DataSourceUtils.createDateRebaseFuncInRead(
Review comment:
Oh which of the PRs has the method rename? I wonder if others will fail
if they don't have that change as well.
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DatasetPrimitiveSuite.scala
##########
@@ -170,23 +170,23 @@ class DatasetPrimitiveSuite extends QueryTest with
SharedSparkSession {
test("groupBy function, map") {
val ds = Seq(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11).toDS()
val grouped = ds.groupByKey(_ % 2)
- val agged = grouped.mapGroups { (g, iter) =>
+ val aggregated = grouped.mapGroups { (g, iter) =>
Review comment:
I don't feel strongly either way, but these don't necessarily need to be
renamed. They're intentionally shorthand it seems. It might just reduce the
number of lines touched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
