HeartSaVioR commented on a change in pull request #28363:
URL: https://github.com/apache/spark/pull/28363#discussion_r532304701
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala
##########
@@ -112,7 +112,16 @@ abstract class CompactibleFileStreamLog[T <: AnyRef :
ClassTag](
* Default implementation retains all log entries. Implementations should
override the method
* to change the behavior.
*/
- def shouldRetain(log: T): Boolean = true
+ def shouldRetain(log: T, context: Map[String, Any]): Boolean = true
Review comment:
Actually the change was made to cover possible general case, because I
got review comment when making change of shouldRetain that "please avoid
breaking backward compatibility." I disagreed as it's a private API based on
the package, but took considerable time and effort to persuade.
If we agree that this is not a public API and shouldn't bother with backward
compatibility with this, I definitely agree this is pretty much overkill as of
now. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
