Ngone51 commented on a change in pull request #30486:
URL: https://github.com/apache/spark/pull/30486#discussion_r532324811
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
##########
@@ -335,6 +335,44 @@ class SparkSubmitSuite
sys.props("SPARK_SUBMIT") should be ("true")
}
+ test("SPARK-33530: handles standalone mode with archives") {
+ val clArgs = Seq(
+ "--master", "spark://localhost:1234",
+ "--executor-memory", "5g",
+ "--executor-cores", "5",
+ "--class", "org.SomeClass",
+ "--jars", "one.jar,two.jar,three.jar",
+ "--driver-memory", "4g",
+ "--files", "file1.txt,file2.txt",
+ "--archives", "archive1.zip,archive2.jar",
+ "--num-executors", "6",
+ "--name", "beauty",
+ "--conf", "spark.ui.enabled=false",
+ "thejar.jar",
+ "arg1", "arg2")
+ val appArgs = new SparkSubmitArguments(clArgs)
+ val (childArgs, classpath, conf, mainClass) =
submit.prepareSubmitEnvironment(appArgs)
+ val childArgsStr = childArgs.mkString(" ")
+ childArgsStr should include ("arg1 arg2")
+ mainClass should be ("org.SomeClass")
+
+ classpath(0) should endWith ("thejar.jar")
+ classpath(1) should endWith ("one.jar")
+ classpath(2) should endWith ("two.jar")
+ classpath(3) should endWith ("three.jar")
+
+ conf.get("spark.executor.memory") should be ("5g")
+ conf.get("spark.driver.memory") should be ("4g")
+ conf.get("spark.executor.cores") should be ("5")
+ conf.get("spark.jars") should include regex
(".*one.jar,.*two.jar,.*three.jar")
+ conf.get("spark.files") should include regex (".*file1.txt,.*file2.txt")
+ conf.get("spark.archives") should include regex
(".*archive1.zip,.*archive2.jar")
+ conf.get("spark.app.name") should be ("beauty")
+ conf.get(UI_ENABLED) should be (false)
+ sys.props("SPARK_SUBMIT") should be ("true")
+ }
+
+
Review comment:
nit: redundant line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
