leanken commented on a change in pull request #30516:
URL: https://github.com/apache/spark/pull/30516#discussion_r532389009
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -195,7 +197,7 @@ case class MakeInterval(
override def inputTypes: Seq[AbstractDataType] = Seq(IntegerType,
IntegerType, IntegerType,
IntegerType, IntegerType, IntegerType,
DecimalType(Decimal.MAX_LONG_DIGITS, 6))
override def dataType: DataType = CalendarIntervalType
- override def nullable: Boolean = true
+ override def nullable: Boolean = if (failOnError)
children.exists(_.nullable) else true
Review comment:
nullable on other two class should be the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
