WeichenXu123 commented on a change in pull request #30539:
URL: https://github.com/apache/spark/pull/30539#discussion_r532425809
##########
File path: python/pyspark/ml/tests/test_tuning.py
##########
@@ -73,7 +73,21 @@ def test_addGrid(self):
.build())
-class CrossValidatorTests(SparkSessionTestCase):
+class ValidatorTestUtilsMixin:
+ def assert_param_maps_equal(self, paramMaps1, paramMaps2):
+ self.assertEqual(len(paramMaps1), len(paramMaps2))
+ for paramMap1, paramMap2 in zip(paramMaps1, paramMaps2):
+ self.assertEqual(set(paramMap1.keys()), set(paramMap2.keys()))
+ for param in paramMap1.keys():
+ v1 = paramMap1[param]
+ v2 = paramMap2[param]
+ if isinstance(v1, Params):
+ self.assertEqual(v1.uid, v2.uid)
+ else:
+ self.assertEqual(v1, v2)
Review comment:
Add strict verification for param maps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
