zero323 commented on a change in pull request #30243:
URL: https://github.com/apache/spark/pull/30243#discussion_r532683935



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -3957,3 +3957,198 @@ case class ArrayExcept(left: Expression, right: 
Expression) extends ArrayBinaryL
 
   override def prettyName: String = "array_except"
 }
+
+/**
+ * Checks if the array (left) has the array (right)
+ */
+@ExpressionDescription(
+  usage = "_FUNC_(array1, array2) - Returns true if the array1 contains the 
array2.",

Review comment:
       > How about we go with `contains_subarray`?
   
   To me, this weekly implies that the function somehow takes into account 
ordering and / or cardinality of the values. However, at the moment, 
implementations seems to work like set(right) ⊆ set(left). So maybe `is_subset` 
would be appropriate, if that's the intended behavior?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to