otterc commented on a change in pull request #30312:
URL: https://github.com/apache/spark/pull/30312#discussion_r530517806



##########
File path: core/src/main/scala/org/apache/spark/storage/BlockId.scala
##########
@@ -81,6 +81,12 @@ case class ShuffleIndexBlockId(shuffleId: Int, mapId: Long, 
reduceId: Int) exten
   override def name: String = "shuffle_" + shuffleId + "_" + mapId + "_" + 
reduceId + ".index"
 }
 
+@Since("3.1.0")
+@DeveloperApi
+case class ShufflePushBlockId(shuffleId: Int, mapIndex: Int, reduceId: Int) 
extends BlockId {

Review comment:
       `ShuffleBlockId` uses `mapId` which is a long. Here we need the mapIndex 
which is int. There was an earlier discussion about this 
[here](https://github.com/apache/spark/pull/30062#discussion_r512908550) which 
is why created `ShufflePushBlockId`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to