Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5144#discussion_r28454143
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
 ---
    @@ -0,0 +1,100 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.scheduler.cluster.mesos
    +
    +import java.util.List
    +import java.util.concurrent.CountDownLatch
    +
    +import scala.collection.JavaConversions._
    +
    +import org.apache.mesos.Protos.{FrameworkInfo, Resource, Status}
    +import org.apache.mesos.{MesosSchedulerDriver, Scheduler}
    +import org.apache.spark.Logging
    +import org.apache.spark.util.Utils
    +
    +/**
    + * Shared trait for implementing a Mesos Scheduler. This holds common 
state and helper
    + * methods and Mesos scheduler will use.
    + */
    +private[mesos] trait MesosSchedulerUtils extends Logging {
    +  // Lock used to wait for scheduler to be registered
    +  private final val registerLatch = new CountDownLatch(1)
    +
    +  // Driver for talking to Mesos
    +  protected var driver: MesosSchedulerDriver = null
    +
    +  /**
    +   * Starts the MesosSchedulerDriver with the provided information. This 
method returns
    +   * until the scheduler has registered with Mesos.
    +   * @param name Name of the scheduler
    +   * @param masterUrl Mesos master connection URL
    +   * @param scheduler Scheduler object
    +   * @param fwInfo FrameworkInfo to pass to the Mesos master
    +   */
    +  def startScheduler(
    +      name: String,
    --- End diff --
    
    once you remove this you can fit the rest of the parameters on L49


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to