brkyvz commented on a change in pull request #30521:
URL: https://github.com/apache/spark/pull/30521#discussion_r533036448
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
##########
@@ -304,46 +308,68 @@ final class DataStreamWriter[T] private[sql](ds:
Dataset[T]) {
* @since 3.1.0
*/
@throws[TimeoutException]
- def saveAsTable(tableName: String): StreamingQuery = {
- this.source = SOURCE_NAME_TABLE
+ def table(tableName: String): StreamingQuery = {
Review comment:
I prefer something like `table`, because:
```
df.writeStream.table("table_name")
```
seems natural to me (though it is missing a `to` to make total sense.
`toTable` also makes sense, but then just `table` is shorter. I wouldn't want
to use `saveAsTable`, because it's not saving really, it's starting a stream
that's continuously saving/updating/overwriting - and the action depends on the
`outputMode`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
