HyukjinKwon commented on a change in pull request #30547:
URL: https://github.com/apache/spark/pull/30547#discussion_r533274491



##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2977,6 +2977,14 @@ private[spark] object Utils extends Logging {
       0
     }
   }
+
+  /**
+   * Returns blockmanager heartbeat timeout as milliseconds.
+   */
+  def blockManagerHeartbeatTimeoutAsMs(conf: SparkConf): Long = {

Review comment:
       I think you don't have to bother with this util and test. You can just 
write down, in the PR description,  that you tested it like this locally 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to