pgandhi999 commented on a change in pull request #28036:
URL: https://github.com/apache/spark/pull/28036#discussion_r533707017



##########
File path: core/src/main/resources/org/apache/spark/ui/static/stagepage.js
##########
@@ -288,14 +298,18 @@ $(document).ready(function () {
         "</a></div>" +
         "<div class='container-fluid-div ml-4 d-none' id='toggle-metrics'>" +
         "<div id='select_all' class='select-all-checkbox-div'><input 
type='checkbox' class='toggle-vis' id='box-0' data-column='0'> Select 
All</div>" +
-        "<div id='scheduler_delay' class='scheduler-delay-checkbox-div'><input 
type='checkbox' class='toggle-vis' id='box-11' data-column='11'> Scheduler 
Delay</div>" +
-        "<div id='task_deserialization_time' 
class='task-deserialization-time-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-12' data-column='12'> Task Deserialization 
Time</div>" +
-        "<div id='shuffle_read_blocked_time' 
class='shuffle-read-blocked-time-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-13' data-column='13'> Shuffle Read Blocked 
Time</div>" +
-        "<div id='shuffle_remote_reads' 
class='shuffle-remote-reads-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-14' data-column='14'> Shuffle Remote Reads</div>" +
-        "<div id='shuffle_write_time' 
class='shuffle-write-time-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-21' data-column='21'> Shuffle Write Time</div>" +
-        "<div id='result_serialization_time' 
class='result-serialization-time-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-15' data-column='15'> Result Serialization 
Time</div>" +
-        "<div id='getting_result_time' 
class='getting-result-time-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-16' data-column='16'> Getting Result Time</div>" +
-        "<div id='peak_execution_memory' 
class='peak-execution-memory-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-17' data-column='17'> Peak Execution Memory</div>" +
+        "<div id='scheduler_delay' class='scheduler-delay-checkbox-div'><input 
type='checkbox' class='toggle-vis' id='box-11' data-column='11' 
column-type='task'> Scheduler Delay</div>" +
+        "<div id='task_deserialization_time' 
class='task-deserialization-time-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-12' data-column='12' column-type='task'> Task 
Deserialization Time</div>" +
+        "<div id='shuffle_read_blocked_time' 
class='shuffle-read-blocked-time-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-13' data-column='13' column-type='task'> Shuffle 
Read Blocked Time</div>" +
+        "<div id='shuffle_remote_reads' 
class='shuffle-remote-reads-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-14' data-column='14' column-type='task'> Shuffle 
Remote Reads</div>" +
+        "<div id='shuffle_write_time' 
class='shuffle-write-time-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-21' data-column='21' column-type='task'> Shuffle 
Write Time</div>" +
+        "<div id='result_serialization_time' 
class='result-serialization-time-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-15' data-column='15' column-type='task'> Result 
Serialization Time</div>" +
+        "<div id='getting_result_time' 
class='getting-result-time-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-16' data-column='16' column-type='task'> Getting 
Result Time</div>" +
+        "<div id='peak_execution_memory' 
class='peak-execution-memory-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='box-17' data-column='17' column-type='task'> Peak 
Execution Memory</div>" +
+        "<div id='executor_jvm_on_off_heap_memory' 
class='executor-jvm-metrics-checkbox-div'><input type='checkbox' 
class='toggle-vis' id='executor-box-15'  data-column='15' 
column-type='executor'> Executor  JVMOnHeapMemory / JVMOffHeapMemory</div>" +

Review comment:
       @ron8hu @AngersZhuuuu If you see the data-column and the id attributes, 
the value in those attributes corresponds to the column placement in the tables 
present in the stages page. Currently, the values for the four new columns are 
overlapping with the other columns, thus, creating errors while loading the 
page. Try fixing the values and testing the same. If it is still not working, 
feel free to ping me and I can look into it with you more.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to