rdblue commented on a change in pull request #30562:
URL: https://github.com/apache/spark/pull/30562#discussion_r533762506
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -221,6 +221,12 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
throw new AnalysisException(s"Exec update failed:" +
s" cannot translate expression to source filter: $f"))
}).toArray
+
+ if (!table.asDeletable.canDeleteWhere(filters)) {
+ throw new AnalysisException(
Review comment:
The rewrite would happen earlier. This just throws a good error message
if `deleteWhere` will fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
