HyukjinKwon commented on a change in pull request #30504:
URL: https://github.com/apache/spark/pull/30504#discussion_r533817332
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala
##########
@@ -263,4 +263,40 @@ class ConstantFoldingSuite extends PlanTest {
comparePlans(optimized, correctAnswer)
}
+
+ test("Constant folding test with sideaffects") {
Review comment:
```suggestion
test("SPARK-33544: Constant folding test with sideaffects") {
```
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala
##########
@@ -263,4 +263,40 @@ class ConstantFoldingSuite extends PlanTest {
comparePlans(optimized, correctAnswer)
}
+
+ test("Constant folding test with sideaffects") {
+ val originalQuery =
+ testRelation
+ .select('a)
+ .where(Size(CreateArray(Seq(AssertTrue(false)))) > 0)
+
+ val optimized = Optimize.execute(originalQuery.analyze)
+ comparePlans(optimized, originalQuery.analyze)
+ }
+
+ object OptimizeForCreate extends RuleExecutor[LogicalPlan] {
+ val batches =
+ Batch("AnalysisNodes", Once,
+ EliminateSubqueryAliases) ::
+ Batch("ConstantFolding", FixedPoint(4),
+ OptimizeIn,
+ ConstantFolding,
+ PruneFilters) :: Nil
+ }
+
+ test("Constant folding test CreateArray") {
Review comment:
```suggestion
test("SPARK-33544: Constant folding test CreateArray") {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
