gatorsmile commented on a change in pull request #30558:
URL: https://github.com/apache/spark/pull/30558#discussion_r533886643
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
##########
@@ -263,6 +266,14 @@ abstract class BaseSessionStateBuilder(
*/
protected def customEarlyScanPushDownRules: Seq[Rule[LogicalPlan]] = Nil
+ /**
+ * Custom rules for rewriting data source plans to add to the Optimizer.
Prefer overriding
+ * this instead of creating your own Optimizer.
+ *
+ * Note that this may NOT depend on the `optimizer` function.
+ */
+ protected def customDataSourceRewriteRules: Seq[Rule[LogicalPlan]] = Nil
Review comment:
This name does not explain the goal. IMO, this is misleading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
