cloud-fan commented on a change in pull request #30560:
URL: https://github.com/apache/spark/pull/30560#discussion_r533951436
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
##########
@@ -160,9 +159,19 @@ trait ExpressionEvalHelper extends
ScalaCheckDrivenPropertyChecks with PlanTestB
expectedErrMsg: String): Unit = {
def checkException(eval: => Unit, testMode: String): Unit = {
+ val modes = if (testMode == "non-codegen mode") {
+ Seq(CodegenObjectFactoryMode.NO_CODEGEN)
+ } else {
+ Seq(CodegenObjectFactoryMode.CODEGEN_ONLY,
CodegenObjectFactoryMode.NO_CODEGEN)
Review comment:
For simplicity, can we always test it with 2 modes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
