HyukjinKwon opened a new pull request #30570: URL: https://github.com/apache/spark/pull/30570
### What changes were proposed in this pull request? This PR is a followup of https://github.com/apache/spark/pull/30504. It proposes: - Rename `NoSideEffect` to `NoThrow` (taken after, e.g.) https://clang.llvm.org/docs/AttributeReference.html#nothrow) - Rename related instances with some more docs clarify expressions that don't throw exceptions. ### Why are the changes needed? `NoSideEffect` here actually means that `Expression.eval` does not throw an exception. It's best to be explicit. I looked if there's a similar name to represent this concept and borrowed the name of [nothrow](https://clang.llvm.org/docs/AttributeReference.html#nothrow). ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manually ran the existing unittests written. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
