HeartSaVioR edited a comment on pull request #30521: URL: https://github.com/apache/spark/pull/30521#issuecomment-737479033
`def toTable(tableName: String, ifNotExist: Boolean = true): StreamingQuery` I'd be OK to do this if we can make a change a bit: 1. `ifNotExist` -> `createIfNotExist` to clarify the meaning 2. default value of `createIfNotExist` should be `false` (the usage should be more simpler to users who don't need to create table) 3. We should leave javadoc that `writeStream` doesn't fully cover the v2 table creation, hence users using v2 table may want to create table in prior (and do nothing specific - again `createIfNotExist` should be `false` by default). Probably with code comment of `TODO: full support of v2 table`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
