huaxingao commented on a change in pull request #30473:
URL: https://github.com/apache/spark/pull/30473#discussion_r534522476
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala
##########
@@ -171,6 +175,130 @@ class JDBCTableCatalog extends TableCatalog with Logging {
}
}
+ override def namespaceExists(namespace: Array[String]): Boolean = namespace
match {
+ case Array(db) =>
+ withConnection { conn =>
+ val rs = conn.getMetaData.getSchemas(null, db)
+ while (rs.next()) {
+ if (rs.getString(1) == db) return true;
+ }
+ false
+ }
+ case _ => false
+ }
+
+ override def listNamespaces(): Array[Array[String]] = {
+ withConnection { conn =>
+ val schemaBuilder = ArrayBuilder.make[Array[String]]
+ val rs = conn.getMetaData.getSchemas()
+ while (rs.next()) {
+ schemaBuilder += Array(rs.getString(1))
+ }
+ schemaBuilder.result
+ }
+ }
+
+ override def listNamespaces(namespace: Array[String]): Array[Array[String]]
= {
+ namespace match {
+ case Array() =>
+ listNamespaces()
+ case Array(db) if namespaceExists(namespace) =>
+ Array()
Review comment:
I am following the implementation in `V2SessionCatalog`
(https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala#L211).
According to the method definition `List namespaces in a namespace`, the
method returns namespaces inside the input `namespace`, which is empty.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala
##########
@@ -171,6 +175,130 @@ class JDBCTableCatalog extends TableCatalog with Logging {
}
}
+ override def namespaceExists(namespace: Array[String]): Boolean = namespace
match {
+ case Array(db) =>
+ withConnection { conn =>
+ val rs = conn.getMetaData.getSchemas(null, db)
+ while (rs.next()) {
+ if (rs.getString(1) == db) return true;
+ }
+ false
+ }
+ case _ => false
+ }
+
+ override def listNamespaces(): Array[Array[String]] = {
+ withConnection { conn =>
+ val schemaBuilder = ArrayBuilder.make[Array[String]]
+ val rs = conn.getMetaData.getSchemas()
+ while (rs.next()) {
+ schemaBuilder += Array(rs.getString(1))
+ }
+ schemaBuilder.result
+ }
+ }
+
+ override def listNamespaces(namespace: Array[String]): Array[Array[String]]
= {
+ namespace match {
+ case Array() =>
+ listNamespaces()
+ case Array(db) if namespaceExists(namespace) =>
+ Array()
+ case _ =>
+ throw new NoSuchNamespaceException(namespace)
+ }
+ }
+
+ override def loadNamespaceMetadata(namespace: Array[String]):
util.Map[String, String] = {
+ namespace match {
+ case Array(db) =>
+ if (!namespaceExists(namespace)) throw new NoSuchNamespaceException(db)
+ mutable.HashMap[String, String]().asJava
+
+ case _ =>
+ throw new NoSuchNamespaceException(namespace)
+ }
+ }
+
+ override def createNamespace(
+ namespace: Array[String],
+ metadata: util.Map[String, String]): Unit = namespace match {
+ case Array(db) if !namespaceExists(namespace) =>
+ var comment = ""
+ if (!metadata.isEmpty) {
+ metadata.asScala.map {
+ case (k, v) => k match {
+ case SupportsNamespaces.PROP_COMMENT => comment = v
+ case SupportsNamespaces.PROP_OWNER => // ignore
+ case SupportsNamespaces.PROP_LOCATION =>
+ throw new AnalysisException("CREATE NAMESPACE ... LOCATION ...
is not supported in" +
+ " JDBC catalog.")
+ case _ => // ignore all the other properties for now
Review comment:
Sure. Fixed this along with the others
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
