Github user ankurdave commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4774#discussion_r28465270
  
    --- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala 
---
    @@ -133,7 +167,29 @@ object PageRank extends Logging {
        *         containing the normalized weight.
        */
       def runUntilConvergence[VD: ClassTag, ED: ClassTag](
    -      graph: Graph[VD, ED], tol: Double, resetProb: Double = 0.15): 
Graph[Double, Double] =
    +     graph: Graph[VD, ED], tol: Double, resetProb: Double = 0.15): 
Graph[Double, Double] =
    +  {
    +      runUntilConvergenceWithOptions(graph, tol, resetProb)
    +  }
    +
    +  /**
    +   * Run a dynamic version of PageRank returning a graph with vertex 
attributes containing the
    +   * PageRank and edge attributes containing the normalized edge weight.
    +   *
    +   * @tparam VD the original vertex attribute (not used)
    +   * @tparam ED the original edge attribute (not used)
    +   *
    +   * @param graph the graph on which to compute PageRank
    +   * @param tol the tolerance allowed at convergence (smaller => more 
accurate).
    +   * @param resetProb the random reset probability (alpha)
    +   * @param srcId the source vertex for a Personalized Page Rank (optional)
    +   *
    +   * @return the graph containing with each vertex containing the PageRank 
and each edge
    +   *         containing the normalized weight.
    +   */
    +  def runUntilConvergenceWithOptions[VD: ClassTag, ED: ClassTag](
    +      graph: Graph[VD, ED], tol: Double, resetProb: Double = 0.15,
    +       srcId: Option[VertexId] = None): Graph[Double, Double] =
    --- End diff --
    
    style: inconsistent indent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to