Github user sryza commented on the pull request:

    https://github.com/apache/spark/pull/5242#issuecomment-93580862
  
    @tgravescs the first will apply to the AM as well if there's not one for 
the AM specifically set:
    
https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java#L380
    
    @vanzin yes, came across that as well.  My concern was mainly about corner 
cases with how these get instantiated - do we need to check 
getAMContainerResourceRequest for null or does it get lazily instantiated.  Not 
big deals at all, but my bandwidth is low right now, and I'm not convinced that 
we should add AM node label expressions until we hear of a use case for them, 
so wanted to put that off for a separate JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to