Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/5144#issuecomment-93587631
  
    Hi @tnachen thanks for cleaning this up. I found the latest set of changes 
much easier to follow. Although I left a bunch of comments many of them are 
quite minor, and this just means that there aren't many large outstanding 
issues left and I have started to pay more attention to the details. I think we 
should be able to finally merge this very soon. Thanks for patiently and 
promptly addressing the reviews so far.
    
    Have you had a chance to test this on a real cluster? I imagine the retry 
and the HA failover logic will be harder to test, but it would be good to 
verify that they actually work. Also, could you post a screen shot of what the 
UI looks like?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to