HyukjinKwon commented on a change in pull request #30577:
URL: https://github.com/apache/spark/pull/30577#discussion_r535185338
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala
##########
@@ -199,6 +199,21 @@ class SparkSessionExtensions {
optimizerRules += builder
}
+ private[this] val dataSourceRewriteRules = mutable.Buffer.empty[RuleBuilder]
+
+ private[sql] def buildDataSourceRewriteRules(session: SparkSession):
Seq[Rule[LogicalPlan]] = {
+ dataSourceRewriteRules.map(_.apply(session))
Review comment:
We're running `Build and test / Scala 2.13 build with SBT (pull_request)
` in Github Actions build. As long as the build pass, we're all good. BTW,
https://github.com/apache/spark/pull/30577#discussion_r534576769 causes a very
annoying bug time to time. But sure, okay to leave it as is and fix all later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]