cloud-fan commented on a change in pull request #30387:
URL: https://github.com/apache/spark/pull/30387#discussion_r535300627
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -136,8 +136,8 @@ trait WindowExecBase extends UnaryExecNode {
val frame =
spec.frameSpecification.asInstanceOf[SpecifiedWindowFrame]
function match {
case AggregateExpression(f, _, _, _, _) => collect("AGGREGATE",
frame, e, f)
- case f: FrameLessOffsetWindowFunction =>
- collect("FRAME_LESS_OFFSET", f.fakeFrame, e, f)
+ case f: FrameLessOffsetWindowFunction => collect(
+ s"FRAME_LESS_OFFSET_${f.ignoreNulls}_${f.input.prettyName}",
f.fakeFrame, e, f)
Review comment:
maybe we should do a refactor here to make the key more flexiable. I
don't think `Expression.prettyName` can be used as a key reliably.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
