WeichenXu123 edited a comment on pull request #30587: URL: https://github.com/apache/spark/pull/30587#issuecomment-738059888
@srowen > a difference of 0.0001 vs 0.0002 could be significant. One possibility is that, the result value will converge to 0, but in limited iterations, it may result in some near zero value like such as 1e-4 or 2e-4, @zhengruifeng Could you help check whether increase iteration will help make than converge fast enough to be zero ? Not sure the best threshold to set here for go into the branch of absTol test. Note: the probably failed test is the `multinomial logistic regression with intercept without regularization with bound` test, this test require to run Bounded-LBFGS algo (not LBFGS), this algo impl in breeze seems is buggy (sometimes unstable or converge slow), the algo is complex and hard to fix tho. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
