Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5116#discussion_r28472055
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/Client.scala ---
    @@ -92,14 +102,15 @@ private class ClientActor(driverArgs: ClientArguments, 
conf: SparkConf)
         println("... waiting before polling master for driver state")
         Thread.sleep(5000)
         println("... polling master for driver state")
    -    val statusFuture = (masterActor ? 
RequestDriverStatus(driverId))(timeout)
    +    val statusFuture = (activeMasterActor ? 
RequestDriverStatus(driverId))(timeout)
           .mapTo[DriverStatusResponse]
         val statusResponse = Await.result(statusFuture, timeout)
    -
         statusResponse.found match {
           case false =>
    -        println(s"ERROR: Cluster master did not recognize $driverId")
    -        System.exit(-1)
    +        statusResponse.exception.getOrElse {
    +          println(s"ERROR: Cluster master did not recognize $driverId")
    +          System.exit(-1)
    +        }
    --- End diff --
    
    This changes behavior. If `statusResponse.exception` is defined then this 
doesn't exit. I would just revert this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to