HeartSaVioR edited a comment on pull request #30521: URL: https://github.com/apache/spark/pull/30521#issuecomment-738618144
Let me clear of follow-up items in my perspective: * figure out the effects when configurations are (provider/partitionBy) conflicting with existing table, and document in javadoc of `toTable`. I think you'll need to make a matrix and describe which takes effect (table vs input) - creating table vs table exists, DSv1 vs DSv2 (4 different situations should be all documented). * document the lack of functionality on creating v2 table in javadoc of `toTable`, and guide that they should ensure table is created in prior to avoid the behavior unintended/insufficient table is being created. Once this is merged either I or @xuanyuanking could file a follow-up JIRA issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
