dongjoon-hyun commented on a change in pull request #30595:
URL: https://github.com/apache/spark/pull/30595#discussion_r535936234
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/TestV2SessionCatalogBase.scala
##########
@@ -70,7 +70,21 @@ private[connector] trait TestV2SessionCatalogBase[T <:
Table] extends Delegating
schema: StructType,
partitions: Array[Transform],
properties: util.Map[String, String]): Table = {
- val created = super.createTable(ident, schema, partitions, properties)
+ val key = TestV2SessionCatalogBase.SIMULATE_ALLOW_EXTERNAL_PROPERTY
+ val propsWithLocation = if (properties.containsKey(key)) {
+ // Always set a location so that CREATE EXTERNAL TABLE won't fail with
LOCATION not specified.
+ if (!properties.containsKey(TableCatalog.PROP_LOCATION)) {
+ val newProps = new util.HashMap[String, String]()
+ newProps.putAll(properties)
+ newProps.put(TableCatalog.PROP_LOCATION, "file:/abc")
+ newProps
+ } else {
+ properties
+ }
+ } else {
+ properties
+ }
+ val created = super.createTable(ident, schema, partitions,
propsWithLocation)
val t = newTable(created.name(), schema, partitions, properties)
Review comment:
Maybe, `properties` -> `propsWithLocation` for consistency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
