Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3074#issuecomment-93610107
@hellertime Functionality-wise this looks fine to me. The comments I left
are relatively minor, mostly to do with code style and clarifying comments. It
appears that a number of watchers have already tested this in their own
deployments :), so I suppose this patch is already in a working state. Once you
address the comments we can do a final round of review and hopefully merge it
in by 1.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
