Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/600#issuecomment-41840032
(sorry for the comment bomb). Okay I looked a bit more... it seems like
this relies on the jar manifest. While it's definitely nice to not hard-code
the version, I see some potential concerns:
1. Someone is running spark without a jar file (e.g. our own unit tests,
when we run spark locally with assemble-deps, etc).
2. Someone has embedded spark in their own assembly jar, in which case the
manifest is not going to inherit from Spark.
In case 2 I think this might silently give the wrong version, i.e. it could
just learn the version from whoever built the assembly.
So it might be worth it to just keep this hard-coded for now... we have
dependencies that rely on META-INF configurations (e.g. datanucleus) and it's
pretty annoying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
