MaxGekk commented on a change in pull request #30615:
URL: https://github.com/apache/spark/pull/30615#discussion_r536534256
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1006,20 +1006,18 @@ case class ShowPartitionsCommand(
DDLUtils.verifyPartitionProviderIsHive(sparkSession, table, "SHOW
PARTITIONS")
/**
- * Validate the partitioning spec by making sure all the referenced
columns are
+ * Normalizes the partition spec w.r.t the partition columns and case
sensitivity settings,
+ * and validates the spec by making sure all the referenced columns are
* defined as partitioning columns in table definition. An
AnalysisException exception is
* thrown if the partitioning spec is invalid.
*/
- if (spec.isDefined) {
- val badColumns =
spec.get.keySet.filterNot(table.partitionColumnNames.contains)
- if (badColumns.nonEmpty) {
- val badCols = badColumns.mkString("[", ", ", "]")
- throw new AnalysisException(
- s"Non-partitioning column(s) $badCols are specified for SHOW
PARTITIONS")
- }
- }
Review comment:
This duplicates the check inside of `normalizePartitionSpec()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
