Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5173#discussion_r28483721
  
    --- Diff: python/pyspark/mllib/util.py ---
    @@ -40,7 +40,7 @@ def _parse_libsvm_line(line, multiclass=None):
             nnz = len(items) - 1
             indices = np.zeros(nnz, dtype=np.int32)
             values = np.zeros(nnz)
    -        for i in xrange(nnz):
    +        for i in range(nnz):
    --- End diff --
    
    Can we use the following instead? Using `range` would hurt performance in 
Python 2 here.
    
    ~~~
    if sys.version >= '3':
        xrange = range
    ~~~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to