maropu commented on a change in pull request #29966: URL: https://github.com/apache/spark/pull/29966#discussion_r537259934
########## File path: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ########## @@ -366,6 +366,29 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu } } + test("SPARK-33084: add jar when path contains comma") { + withTempDir { tmpDir => + val tmpJar = File.createTempFile("Test,UDTF", ".jar", tmpDir) + sc = new SparkContext(new SparkConf().setAppName("test").setMaster("local")) + sc.addJar(tmpJar.getAbsolutePath) + assert(sc.listJars().exists(_.contains("Test,UDTF"))) Review comment: https://github.com/apache/spark/pull/29966#issuecomment-739631644 hm, I think it would be better to check jars are added correctly in executors, too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org