MaxGekk commented on a change in pull request #30624:
URL: https://github.com/apache/spark/pull/30624#discussion_r537304171
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala
##########
@@ -51,14 +61,16 @@ object ResolvePartitionSpec extends Rule[LogicalPlan] {
private def resolvePartitionSpecs(
tableName: String,
partSpecs: Seq[PartitionSpec],
- partSchema: StructType): Seq[ResolvedPartitionSpec] =
+ partSchema: StructType,
+ checkSpec: TablePartitionSpec => Unit = _ => ()):
Seq[ResolvedPartitionSpec] =
Review comment:
We shouldn't call it in all cases, for instance, we shouldn't call it
for `SHOW PARTITIONS`.
I thought about alternative solution by passing a flag and check the flag
but just passing the function looks more clearly and beauty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
