yaooqinn opened a new pull request #30642:
URL: https://github.com/apache/spark/pull/30642


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
        
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   
   In this PR, we made SharedState JVM-wide accessible even after the active 
and default sessions are cleared. In this way, all the **STATIC SQL CONFIGS CAN 
BE STATIC**. Because w/o this PR, after the active and default sessions are 
cleared, the later created SparkSession instances are able to recreate a 
SharedState instance which can have a different metastore connection, global 
temp database, and other static configs reset.
   
   Besides, as a follow-up of https://github.com/apache/spark/pull/30045, we 
modify the RESET command here to respect the session initial configs per 
session first then fall back to the `SharedState` conf, which makes each 
session could maintain a different copy of initial configs for resetting.
   
   
   ### Why are the changes needed?
   
   to make reset command saner.
   ### Does this PR introduce _any_ user-facing change?
   
   yes, 
   1)After `clearActive(Default)Session` called, the static configs and things 
created that related to them will not change
   2) RESET will respect session initials first not always go to the system 
defaults
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   -->
   
   add new tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to