Github user rtreffer commented on the pull request:
https://github.com/apache/spark/pull/5498#issuecomment-93677337
@marmbrus thank you, I'll fix those issues and open a new one when done.
Regarding naming/api:
It is quite common that there is one class per sql/jdbc dialect. Often
called that way (e.g. MySQLDialect on hibernate). I've found quite some
projects that use the same naming (via github search).
Anyway, in this case I'd like to match those namings and add a default
implementation per method (returning the neutral element).
On the other hand it's currently just doing type mapping. So
JDBCTypeMapping would be a very valid name, too. It would restrict the use case
more (can be good or bad).
I guess you know better what would suite spark :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
